Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
coverage: 83.058% (-0.05%) from 83.105% — fix-2397 into master |
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Looks pretty good to me already 🚀
I have one minor concern inline. please have a look :)
| if (segments.length === 0) { | ||
| return value; | ||
| } |
There was a problem hiding this comment.
''.split('.') returns [''], never [], so this guard is unreachable. An empty path falls through to assign(container, '', value), which writes to key ''.That happens to match the old lodash behavior (setFp('', v, {b:2}) → {b:2, '': v}), so it's not a regression, but the guard is misleading.
Should we drop it, or if the intent was to treat an empty path as "replace root", handle that explicitly?
| if (segments.length === 0) { | ||
| return data; | ||
| } |
There was a problem hiding this comment.
3 participants
Replace the lodash/fp/set call in UPDATE_DATA with a dedicated helper. This fixes issues with numeric segments (e.g. "group-key.15") and bracket characters in property names (e.g. "test[0]").
Fixes #2102
Fixes #2397